-
-
Notifications
You must be signed in to change notification settings - Fork 402
[skip-changelog] Migrate tests from test_compile_part_4.py
to compile_part_4_test.go
#1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44e3be2
to
29130c6
Compare
081f997
to
6e329eb
Compare
69ed727
to
f25b5e0
Compare
cmaglie
reviewed
Nov 9, 2022
… compile_part_4_test.go
… to compile_part_4_test.go
…part_4.py to compile_part_4_test.go
…4.py to compile_part_4_test.go
….py to compile_part_4_test.go
…_4.py to compile_part_4_test.go
…art_4.py to compile_part_4_test.go
…py to compile_part_4_test.go
…py to compile_part_4_test.go
…o compile_part_4_test.go
…test_compile_part_4.py to compile_part_4_test.go
…rt_4.py to compile_part_4_test.go
…test_compile_part_4.py to compile_part_4_test.go
…to compile_part_4_test.go
…nd delete test_compile_part_4.py
f25b5e0
to
517a54e
Compare
cmaglie
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_compile_part_4.py
have been rewritten incompile_part_4_test.go
, without changing their original purpose.Does this PR introduce a breaking change, and is titled accordingly?
No