Skip to content

[skip-changelog] Migrate tests from test_compile_part_4.py to compile_part_4_test.go #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 16, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_compile_part_4.py have been rewritten in compile_part_4_test.go, without changing their original purpose.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 14, 2022
@MatteoPologruto MatteoPologruto self-assigned this Oct 14, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review October 14, 2022 13:48
@MatteoPologruto MatteoPologruto force-pushed the compile-4 branch 2 times, most recently from 081f997 to 6e329eb Compare October 17, 2022 14:14
@MatteoPologruto MatteoPologruto force-pushed the compile-4 branch 2 times, most recently from 69ed727 to f25b5e0 Compare November 7, 2022 15:09
…test_compile_part_4.py to compile_part_4_test.go
…test_compile_part_4.py to compile_part_4_test.go
@MatteoPologruto MatteoPologruto merged commit 0c823ea into arduino:master Nov 16, 2022
@MatteoPologruto MatteoPologruto deleted the compile-4 branch November 16, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants